Fix cached runtime embedding across feature builds - #551
Merged
Merged
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
jprendes
approved these changes
Sep 16, 2026
jprendes
pushed a commit
to hyperlight-dev/hyperlight-js
that referenced
this pull request
Sep 21, 2026
Copy the selected runtime into `OUT_DIR` and use that copy for embedding. Default and `trace_guest` builds share one runtime output path. A `trace_guest` build can overwrite that file while Cargo retains the default build script's cached output. A later default library compilation then embeds the trace-enabled runtime. Each configuration's `OUT_DIR` copy preserves its runtime. The nested Cargo target directory remains shared to reuse compiled dependencies. Custom runtimes supplied through `HYPERLIGHT_JS_RUNTIME_PATH` retain their existing environment and source-file tracking. ### Original Reproduction ```sh cargo build --release -p hyperlight-js cargo build --release -p hyperlight-js --features trace_guest cargo build --release -p hyperlight-js ``` Before this fix, the third build embedded the trace-enabled runtime despite requesting default Uses the same approach as in in hyperlight-dev/hyperlight-wasm#551. Fixes #296 Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the built runtime into
OUT_DIRand use that copy for embedding and build metadata.Native and Pulley builds share one runtime output path. Pulley can overwrite that file while Cargo retains the native build script’s cached output. A later native library compilation then embeds Pulley.
Each configuration’s
OUT_DIRcopy preserves its runtime. The nested Cargo target directory remains shared to reuse compiled dependencies.Original Reproduction
Before this fix, the third build can embed Pulley despite requesting native.
Why File Tracking Is Insufficient
Adding
cargo::rerun-if-changedfor the shared binary can miss changes. Nested Cargo can restore a cached binary whose modification time predates the native build script’s last run.With that directive present, first warm both runtime caches:
Then clear only the outer package’s artifacts and reproduce:
The final build recompiles the native library but reuses its cached build-script output. It embeds the shared Pulley binary.
touchchanges only the source timestamp.Fixes #547